Change in libosmocore[master]: ns2: refactor handle_nsip_read/handle_nsfrgre_read

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

lynxis lazus gerrit-no-reply at lists.osmocom.org
Thu Sep 24 13:54:10 UTC 2020


lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/20269 )

Change subject: ns2: refactor handle_nsip_read/handle_nsfrgre_read
......................................................................


Patch Set 1:

(2 comments)

https://gerrit.osmocom.org/c/libosmocore/+/20269/1/src/gb/gprs_ns2_frgre.c 
File src/gb/gprs_ns2_frgre.c:

https://gerrit.osmocom.org/c/libosmocore/+/20269/1/src/gb/gprs_ns2_frgre.c@a458 
PS1, Line 458: 			return 0;
> Leaking msg?
never only in a separate patch


https://gerrit.osmocom.org/c/libosmocore/+/20269/1/src/gb/gprs_ns2_udp.c 
File src/gb/gprs_ns2_udp.c:

https://gerrit.osmocom.org/c/libosmocore/+/20269/1/src/gb/gprs_ns2_udp.c@a207 
PS1, Line 207: 			return 0;
> Are you leaking msg here?
Ack



-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/20269
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ieb273371877dbc7e5b321c3b377e7142e43668d9
Gerrit-Change-Number: 20269
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu>
Gerrit-Comment-Date: Thu, 24 Sep 2020 13:54:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: daniel <dwillmann at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200924/d7d25647/attachment.htm>


More information about the gerrit-log mailing list