Change in libosmocore[master]: gb/gprs_bssgb: ensure the fc timer has been stopped when freeing bssg...

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

lynxis lazus gerrit-no-reply at lists.osmocom.org
Thu Sep 24 13:38:33 UTC 2020


lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/20263 )

Change subject: gb/gprs_bssgb: ensure the fc timer has been stopped when freeing bssgp_bvc
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/c/libosmocore/+/20263/1/src/gb/gprs_bssgp.c 
File src/gb/gprs_bssgp.c:

https://gerrit.osmocom.org/c/libosmocore/+/20263/1/src/gb/gprs_bssgp.c@174 
PS1, Line 174: 	osmo_timer_del(&ctx->fc->timer);
> timer is freed here and it can happen if no osmo_timer_fd_setup is done on it. […]
It's not a problem to delete a timer which isn't setup()ed.
The timer is not freed by del() and fc->timer is always valid.



-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/20263
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Id03ebef31bb513e2b3b5bc709a91e9352ebbbc79
Gerrit-Change-Number: 20263
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Thu, 24 Sep 2020 13:38:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200924/bbff1bd1/attachment.htm>


More information about the gerrit-log mailing list