This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
pespin gerrit-no-reply at lists.osmocom.orgpespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/20245 ) Change subject: Free all MS TBFs when receiving GPRS Suspension Request ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/c/osmo-pcu/+/20245/1/src/pcu_l1_if.cpp File src/pcu_l1_if.cpp: https://gerrit.osmocom.org/c/osmo-pcu/+/20245/1/src/pcu_l1_if.cpp@750 PS1, Line 750: ms->dl_tbf > And why don't you just call ~GprsMs()? Because that's not how deallocation works in PDCH. Lifecycle is really complex (too much imho). The deallocation of ms object is meant to be done through unreferencing, and never directly, but through dropping TBFs. I spent quite a lot of time finding the correct way to do this and test it to getting it done right and spotting no crash afterwards. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/20245 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I4ae1c3706b2ed6e4d271cd16f7cd7f8937b84836 Gerrit-Change-Number: 20245 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Tue, 22 Sep 2020 16:09:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy at sysmocom.de> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200922/1a57eea2/attachment.htm>