Change in osmo-bsc[master]: vty: add attributes to VTY commands indicating when they apply

[dexter]

dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/19670 )

Change subject: vty: add attributes to VTY commands indicating when they apply
......................................................................


Patch Set 6:

(1 comment)

Just thought that I could share a few ideas.

https://gerrit.osmocom.org/c/osmo-bsc/+/19670/6/include/osmocom/bsc/vty.h 
File include/osmocom/bsc/vty.h:

https://gerrit.osmocom.org/c/osmo-bsc/+/19670/6/include/osmocom/bsc/vty.h@38 
PS6, Line 38: enum bsc_vty_cmd_attr {
I just wonder if there could be a VTY_ATTR_RESTART_FULL predefined in libosmore. Almost any of the osmo program will need it. Maybe also an VTY_ATTR_RESTART_IMMEDIATE?

Maybe drop the prefix BSC_ - this would also minimze the chance for copy+paste errors. Or maybe keep the prefix to distinguish between pred-defined and custom attrebutes?



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/19670
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I3bf9223295fc4a2fcb4046a1f29f792ff6a41d51
Gerrit-Change-Number: 19670
Gerrit-PatchSet: 6
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Assignee: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Tue, 22 Sep 2020 10:06:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200922/38bb0115/attachment.htm>