Change in osmo-ttcn3-hacks[master]: pcu: Check stats for pcu channel allocation, bytes transferred

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

daniel gerrit-no-reply at lists.osmocom.org
Tue Sep 22 07:18:21 UTC 2020


daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20226 )

Change subject: pcu: Check stats for pcu channel allocation, bytes transferred
......................................................................


Patch Set 2:

> Patch Set 2:
> 
> I believe we should add separate test cases verifying different counters rather than selectively mixing the new checks with the existing test cases. Let me know if I can help with that.

I agree for some counters like uncommon errors.

But why shouldn't we verify the counters for regular tests?
One reason would be because a counter failure would fail a test that tests the actual functionality while the functionality still works. I'm not sure how often that will happen, though and if/once we trust our counters they can also help verify assumptions made in a testcase.


-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20226
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I90964b32fa11ed2582afc5fb56bd302b06606f86
Gerrit-Change-Number: 20226
Gerrit-PatchSet: 2
Gerrit-Owner: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Tue, 22 Sep 2020 07:18:21 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200922/02391b35/attachment.htm>


More information about the gerrit-log mailing list