Change in osmo-mgw[master]: mgw: Avoid logging notice message each time we receive nt param in LCO

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Mon Sep 21 14:41:09 UTC 2020


pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/20221 )

Change subject: mgw: Avoid logging notice message each time we receive nt param in LCO
......................................................................

mgw: Avoid logging notice message each time we receive nt param in LCO

We don't really use it so far and it doesn't deserve a NOTICE message.

Change-Id: I058dc37fe6229e879284a8f5e7677d6016129c47
---
M src/libosmo-mgcp/mgcp_protocol.c
1 file changed, 5 insertions(+), 0 deletions(-)

Approvals:
  fixeria: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/libosmo-mgcp/mgcp_protocol.c b/src/libosmo-mgcp/mgcp_protocol.c
index 5523761..902c079 100644
--- a/src/libosmo-mgcp/mgcp_protocol.c
+++ b/src/libosmo-mgcp/mgcp_protocol.c
@@ -524,6 +524,7 @@
 {
 	char *lco_id;
 	char codec[17];
+	char nt[17];
 	int len;
 
 	if (!options)
@@ -562,6 +563,10 @@
 				osmo_str_toupper_buf(lco->codec, len + 1, codec);
 			}
 			break;
+		case 'n':
+			if (lco_id[1] == 't' && sscanf(lco_id + 2, ":%16[^,]", nt) == 1)
+				break;
+			/* else: fall throught to print notice log */
 		default:
 			LOGP(DLMGCP, LOGL_NOTICE,
 			     "LCO: unhandled option: '%c'/%d in \"%s\"\n",

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/20221
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: I058dc37fe6229e879284a8f5e7677d6016129c47
Gerrit-Change-Number: 20221
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200921/8a5a338d/attachment.htm>


More information about the gerrit-log mailing list