Change in osmo-msc[master]: Introduce RNC paging attempts and timeout

[fixeria]

fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/15494 )

Change subject: Introduce RNC paging attempts and timeout
......................................................................


Patch Set 11: Code-Review-1

(4 comments)

https://gerrit.osmocom.org/c/osmo-msc/+/15494/11/src/libmsc/msc_vty.c 
File src/libmsc/msc_vty.c:

https://gerrit.osmocom.org/c/osmo-msc/+/15494/11/src/libmsc/msc_vty.c@566 
PS11, Line 566: rnc
In the commit message you state that RNC is not responsible for paging, and it's the task of the MSC itself, so why do we have this prefix here? I find this a bit confusing, because it looks like a parameter that we somehow indicate to the RNC. Let's better use RAN type here as a prefix - 'utran' or '3g'.


https://gerrit.osmocom.org/c/osmo-msc/+/15494/11/src/libmsc/msc_vty.c@575 
PS11, Line 575:  {
cosmetic: drop curly braces


https://gerrit.osmocom.org/c/osmo-msc/+/15494/11/src/libmsc/msc_vty.c@582 
PS11, Line 582: response-timer
I believe we should move to generic timer configuration commands, and we already have them in the 'msc' section:

  timer [(vlr|mgw|mncc|sccp|geran|utran|sgs)] [TNNNN] [(<0-2147483647>|default)]

this one would go to 'utran'. We just need to assign a new TNNNN.

I know that we already have 'paging response-timer' for GERAN as a separate command, but it does not mean that we should populate the timer commands zoo with even more different entries. Ideally we need to deprecate this command and move it to 'geran' (see above). The new TNNNN should be the same for both GERAN and UTRAN.


https://gerrit.osmocom.org/c/osmo-msc/+/15494/11/src/libmsc/paging.c 
File src/libmsc/paging.c:

https://gerrit.osmocom.org/c/osmo-msc/+/15494/11/src/libmsc/paging.c@63 
PS11, Line 63: LOGL_ERROR
Is it really an ERROR? Maybe rather NOTICE or even INFO?



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/15494
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I32c47958939a4a29292832289f9d29905731d7f3
Gerrit-Change-Number: 15494
Gerrit-PatchSet: 11
Gerrit-Owner: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: efistokl <mykola at kingmuffin.com>
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Sat, 12 Sep 2020 08:12:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200912/d5100aa2/attachment.htm>