This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
matt9j gerrit-no-reply at lists.osmocom.orgmatt9j has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo_ss7/+/20018 ) Change subject: ipa_proto: Implement ccm response with variable options ...................................................................... Patch Set 1: (2 comments) > Patch Set 1: Code-Review+1 > > (2 comments) Thank you for the review! https://gerrit.osmocom.org/c/erlang/osmo_ss7/+/20018/1/src/ipa_proto.erl File src/ipa_proto.erl: https://gerrit.osmocom.org/c/erlang/osmo_ss7/+/20018/1/src/ipa_proto.erl@97 PS1, Line 97: set_ccm_options > This looks like a public API, so we don't you -export() it? The module already does an export_all. I did not add an export for this function since others were not explicitly exported either. You are correct that it is intended as public API though. https://gerrit.osmocom.org/c/erlang/osmo_ss7/+/20018/1/src/ipa_proto.erl@257 PS1, Line 257: Result > Cosmetic: you could embed ipa_proto:request() call here: […] Ack: I will push a new change with this incorporated. -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_ss7/+/20018 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo_ss7 Gerrit-Branch: master Gerrit-Change-Id: I3f67095f33f1ff826ad04dad72990bf79617149a Gerrit-Change-Number: 20018 Gerrit-PatchSet: 1 Gerrit-Owner: matt9j <matt9j at cs.washington.edu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de> Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Reviewer: matt9j <matt9j at cs.washington.edu> Gerrit-Comment-Date: Fri, 11 Sep 2020 21:03:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy at sysmocom.de> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200911/45c91847/attachment.htm>