This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
pespin gerrit-no-reply at lists.osmocom.orgpespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/20076 )
Change subject: radioDevice: fix set_antennas(): consider MULTI_ARFCN mode
......................................................................
Patch Set 1: Code-Review-1
(1 comment)
https://gerrit.osmocom.org/c/osmo-trx/+/20076/1/Transceiver52M/device/common/radioDevice.h
File Transceiver52M/device/common/radioDevice.h:
https://gerrit.osmocom.org/c/osmo-trx/+/20076/1/Transceiver52M/device/common/radioDevice.h@189
PS1, Line 189: for (i = 0; i < tx_paths_len; i++) {
What about simply iterating over "chans"? that's already set to 1 in multiarfcn mode during consturctor of RadioDevice.
for (i = 0; i < chans; i++) {
--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/20076
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: I09f316f181cbbc2214e8913b73f7c1fcea4e8c05
Gerrit-Change-Number: 20076
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Fri, 11 Sep 2020 20:55:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200911/424884fc/attachment.htm>