This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
dexter gerrit-no-reply at lists.osmocom.orgdexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-mgw/+/20092 ) Change subject: mgcp_network: fix coverity false positive ...................................................................... mgcp_network: fix coverity false positive The function recvfrom gets a struct sockaddr *src_addr and a socklen_t *addrlen parameter. The addrlen parameter specifies the length of src_addr, which is 16 bytes, but we give it the size of struct osmo_sockaddr instead, which is much longer. This is not problematic, but for some reason coverity detects a memory corruption, so lets give the actual size of struct sockaddr as input instead. Change-Id: I14f22d161c242ae518009679b584f983e0b63ca0 Fixes: CID 214229 --- M src/libosmo-mgcp/mgcp_network.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/92/20092/1 diff --git a/src/libosmo-mgcp/mgcp_network.c b/src/libosmo-mgcp/mgcp_network.c index fa40f1f..b3919f3 100644 --- a/src/libosmo-mgcp/mgcp_network.c +++ b/src/libosmo-mgcp/mgcp_network.c @@ -1412,7 +1412,7 @@ struct mgcp_conn_rtp *conn_src; struct mgcp_endpoint *endp; struct osmo_sockaddr addr; - socklen_t slen = sizeof(addr); + socklen_t slen = sizeof(addr.u.sa); char ipbuf[INET6_ADDRSTRLEN]; int ret; enum rtp_proto proto; -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/20092 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I14f22d161c242ae518009679b584f983e0b63ca0 Gerrit-Change-Number: 20092 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier at sysmocom.de> Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200911/f4f235e3/attachment.htm>