Change in osmo-e1d[master]: make sure a given timeslot can only be opened once (by default)

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

tnt gerrit-no-reply at lists.osmocom.org
Fri Sep 11 15:38:44 UTC 2020


tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/20081 )

Change subject: make sure a given timeslot can only be opened once (by default)
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

Looks good except for the protocol version number needing a bump.

https://gerrit.osmocom.org/c/osmo-e1d/+/20081/1/include/osmocom/e1d/proto.h 
File include/osmocom/e1d/proto.h:

https://gerrit.osmocom.org/c/osmo-e1d/+/20081/1/include/osmocom/e1d/proto.h@89 
PS1, Line 89: #define E1DP_MAGIC	0x01e1
This breaks protocol compatibility and so the version number needs a bump.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/20081
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-e1d
Gerrit-Branch: master
Gerrit-Change-Id: Ib25adf827ec41e74de15e0e4fdcfc9bcc9a32e58
Gerrit-Change-Number: 20081
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Assignee: tnt <tnt at 246tNt.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: tnt <tnt at 246tNt.com>
Gerrit-Comment-Date: Fri, 11 Sep 2020 15:38:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200911/7470d32c/attachment.htm>


More information about the gerrit-log mailing list