Change in osmo-bsc[master]: abis_nm: make a HACK in abis_nm_ipaccess_cgi() less confusing

[fixeria]

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/20082 )


Change subject: abis_nm: make a HACK in abis_nm_ipaccess_cgi() less confusing
......................................................................

abis_nm: make a HACK in abis_nm_ipaccess_cgi() less confusing

Change-Id: Ideed271ca7453e98d153deb8aa0aefa7020b75ec
Fixes: CID#208178
---
M src/osmo-bsc/abis_nm.c
1 file changed, 4 insertions(+), 3 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/82/20082/1

diff --git a/src/osmo-bsc/abis_nm.c b/src/osmo-bsc/abis_nm.c
index d88ce24..01b304e 100644
--- a/src/osmo-bsc/abis_nm.c
+++ b/src/osmo-bsc/abis_nm.c
@@ -3014,10 +3014,11 @@
 {
 	struct gsm48_ra_id *_buf = (struct gsm48_ra_id*)buf;
 	uint16_t ci = htons(bts->cell_identity);
-	/* we simply reuse the GSM48 function and write the Cell ID over the position where the RAC
-	 * starts */
+
+	/* HACK: we simply reuse the existing GSM48 function and write
+	 * the Cell ID over the position where the RAC starts. */
 	gsm48_ra_id_by_bts(_buf, bts);
-	memcpy(&_buf->rac, &ci, sizeof(ci));
+	memcpy(buf + sizeof(struct gsm48_ra_id) - 1, &ci, sizeof(ci));
 }
 
 static const struct value_string ipacc_testres_names[] = {

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/20082
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Ideed271ca7453e98d153deb8aa0aefa7020b75ec
Gerrit-Change-Number: 20082
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200911/afb53962/attachment.htm>