Change in osmo-pcu[master]: encoding: fix gen_freq_params(): do not check pdch twice

[fixeria]

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/20060 )

Change subject: encoding: fix gen_freq_params(): do not check pdch twice
......................................................................

encoding: fix gen_freq_params(): do not check pdch twice

This is a left-over from an earlier version of [1] that makes
Coverity think that there can be NULL pointer dereference,
even despite we assert(pdch != NULL).

[1] I8adc0cdb1b05a87b4df5d4bc196f6d381283a06f

Change-Id: I3490c38e0c1186dfd2fae63526a05c694547cebb
Fixes: CID#214230
---
M src/encoding.cpp
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Jenkins Builder: Verified
  pespin: Looks good to me, approved



diff --git a/src/encoding.cpp b/src/encoding.cpp
index ecf40de..d581fe9 100644
--- a/src/encoding.cpp
+++ b/src/encoding.cpp
@@ -565,7 +565,7 @@
 	freq_params->TSC = pdch->tsc;
 
 	/* If frequency hopping is not in use, encode a single ARFCN */
-	if (pdch == NULL || !pdch->fh.enabled) {
+	if (!pdch->fh.enabled) {
 		freq_params->UnionType = 0x00;
 		freq_params->u.ARFCN = tbf->trx->arfcn;
 		return;

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/20060
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I3490c38e0c1186dfd2fae63526a05c694547cebb
Gerrit-Change-Number: 20060
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200911/334e1457/attachment.htm>