This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
dexter gerrit-no-reply at lists.osmocom.orgdexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/20078 ) Change subject: abis_rsl: fix memleak in rach dos reduction function ...................................................................... abis_rsl: fix memleak in rach dos reduction function The function reduce_rach_dos() only removes the tossed channel requests from the list, but does not free them. Change-Id: I0a62fc897c07e118dd637b156b6f2822c44db731 Related: OS#4549 --- M src/osmo-bsc/abis_rsl.c 1 file changed, 4 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/78/20078/1 diff --git a/src/osmo-bsc/abis_rsl.c b/src/osmo-bsc/abis_rsl.c index 347be12..2af01d9 100644 --- a/src/osmo-bsc/abis_rsl.c +++ b/src/osmo-bsc/abis_rsl.c @@ -1389,6 +1389,7 @@ "(ra=0x%02x, neci=0x%02x, chreq_reason=0x%02x)\n", rqd->ref.ra, bts->network->neci, rqd->reason); llist_del(&rqd->entry); + talloc_free(rqd); } else { rqd_count++; } @@ -1398,7 +1399,9 @@ * problem with RACH dos on this BTS. We drop the first entry in the list to clip the growth of the list. */ if (rqd_count > 255) { LOG_BTS(bts, DRSL, LOGL_INFO, "CHAN RQD: more than 255 queued RACH requests -- RACH DoS attack?\n"); - llist_del(&llist_first_entry(&bts->chan_rqd_queue, struct chan_rqd, entry)->entry); + rqd = llist_first_entry(&bts->chan_rqd_queue, struct chan_rqd, entry); + llist_del(&rqd->entry); + talloc_free(rqd); } } -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/20078 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I0a62fc897c07e118dd637b156b6f2822c44db731 Gerrit-Change-Number: 20078 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier at sysmocom.de> Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200911/03d87f1c/attachment.htm>