Change in osmo-msc[pespin/1.6.2]: fix crash for unknown MI during Paging Response

[pespin]

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/20050 )

Change subject: fix crash for unknown MI during Paging Response
......................................................................

fix crash for unknown MI during Paging Response

This patch is a cherry-pick from master's
667d5e0b95d01946ba5e80ae7e202576c05cc5c1, to create a new patch release
to avoid osmo-msc crash during ttcn3-msc-tests-latest run.

Related: OS#4724
Related: I40496bbccbbd9c496cfa57df49e26f124a2b1554 (osmo-ttcn3-hacks)
Change-Id: Ia2c8fa745cfab17ed7114d433f625ddc02ae7b11
---
M src/libmsc/gsm_04_08.c
1 file changed, 6 insertions(+), 1 deletion(-)

Approvals:
  neels: Looks good to me, approved
  pespin: Verified



diff --git a/src/libmsc/gsm_04_08.c b/src/libmsc/gsm_04_08.c
index b284ccd..3594bfc 100644
--- a/src/libmsc/gsm_04_08.c
+++ b/src/libmsc/gsm_04_08.c
@@ -1185,7 +1185,12 @@
 	vsub = msc_a_vsub(msc_a);
 	if (!vsub) {
 		LOG_MSC_A(msc_a, LOGL_ERROR, "subscriber not allowed to do a Paging Response\n");
-		msc_a_put(msc_a, MSC_A_USE_PAGING_RESPONSE);
+
+		/* Above MSC_A_USE_PAGING_RESPONSE may already have been removed by a forced release, put that use only
+		 * if it still exists. (see msc_a_fsm_releasing_onenter()) */
+		if (osmo_use_count_by(&msc_a->use_count, MSC_A_USE_PAGING_RESPONSE))
+			msc_a_put(msc_a, MSC_A_USE_PAGING_RESPONSE);
+
 		return -EIO;
 	}
 

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/20050
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: pespin/1.6.2
Gerrit-Change-Id: Ia2c8fa745cfab17ed7114d433f625ddc02ae7b11
Gerrit-Change-Number: 20050
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200909/e425322b/attachment.htm>