This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
pespin gerrit-no-reply at lists.osmocom.orgpespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20033 ) Change subject: mgw: Allow setting udp ip/port with wildcard osmux in f_flow_create_osmux() ...................................................................... mgw: Allow setting udp ip/port with wildcard osmux in f_flow_create_osmux() This will be needed once IPv4+IPv6 support is used, since we want to set the remote IP addr in CRCX for convinience to get an IP adr from ther same family during CRCX, while still allowing for testing Osmux CID wildcard value. Change-Id: I3abd80b1c0053004aab3d03e09fada1129a59765 --- M mgw/MGCP_Test.ttcn 1 file changed, 7 insertions(+), 4 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve fixeria: Looks good to me, approved Jenkins Builder: Verified diff --git a/mgw/MGCP_Test.ttcn b/mgw/MGCP_Test.ttcn index 24bfdaf..deb9f3e 100644 --- a/mgw/MGCP_Test.ttcn +++ b/mgw/MGCP_Test.ttcn @@ -417,10 +417,13 @@ * part that tells the MGW where we are listening for Osmux streams * that come from the MGW. We get a fully working connection in * one go. */ - rx_hdl := c_OsmuxemDefaultRxHandle; - rx_hdl.cid := flow.osmux_cid; - f_osmuxem_register_rxhandle(pt, rx_hdl); - flow.osmux_cid_sent := true; + if (flow.osmux_cid != -1) { + /* We may still want to negotiate osmux CID later at MDCX */ + rx_hdl := c_OsmuxemDefaultRxHandle; + rx_hdl.cid := flow.osmux_cid; + f_osmuxem_register_rxhandle(pt, rx_hdl); + flow.osmux_cid_sent := true; + } cmd := ts_CRCX_osmux(get_next_trans_id(), ep, mode, call_id, flow.osmux_cid); cmd.sdp := ts_SDP(flow.em.hostname, flow.em.hostname, "23", "42", flow.em.portnr, { int2str(flow.pt) }, attributes); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20033 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I3abd80b1c0053004aab3d03e09fada1129a59765 Gerrit-Change-Number: 20033 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de> Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200909/c4f2ac20/attachment.htm>