Change in osmo-msc[master]: Support handling IPv6 Transport Address in Assignment Complete

[pespin]

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/19949 )

Change subject: Support handling IPv6 Transport Address in Assignment Complete
......................................................................

Support handling IPv6 Transport Address in Assignment Complete

Change-Id: Ib650bb063404a3068b4cf3c376c6080dc29bebfe
---
M src/libmsc/ran_msg_a.c
1 file changed, 1 insertion(+), 10 deletions(-)

Approvals:
  Jenkins Builder: Verified
  dexter: Looks good to me, but someone else must approve
  pespin: Looks good to me, approved
  laforge: Looks good to me, but someone else must approve
  fixeria: Looks good to me, but someone else must approve



diff --git a/src/libmsc/ran_msg_a.c b/src/libmsc/ran_msg_a.c
index c17eb3d..c859c22 100644
--- a/src/libmsc/ran_msg_a.c
+++ b/src/libmsc/ran_msg_a.c
@@ -279,7 +279,6 @@
 	struct tlv_p_entry *ie_codec_list_bss_supported = TLVP_GET(tp, GSM0808_IE_SPEECH_CODEC_LIST);
 	struct tlv_p_entry *ie_osmux_cid = TLVP_GET(tp, GSM0808_IE_OSMO_OSMUX_CID);
 	struct sockaddr_storage rtp_addr;
-	struct sockaddr_in *rtp_addr_in;
 	struct gsm0808_speech_codec sc;
 	struct gsm0808_speech_codec_list codec_list_bss_supported;
 	int rc;
@@ -296,15 +295,7 @@
 			return -EINVAL;
 		}
 
-		rtp_addr_in = (struct sockaddr_in*)&rtp_addr;
-
-		if (rtp_addr.ss_family != AF_INET) {
-			LOG_RAN_A_DEC_MSG(LOGL_ERROR, "Assignment Complete: IE AoIP Transport Address:"
-				 " unsupported addressing scheme (only IPV4 supported)\n");
-			return -EINVAL;
-		}
-
-		if (osmo_sockaddr_str_from_sockaddr_in(&ran_dec_msg.assignment_complete.remote_rtp, rtp_addr_in)) {
+		if (osmo_sockaddr_str_from_sockaddr(&ran_dec_msg.assignment_complete.remote_rtp, &rtp_addr)) {
 			LOG_RAN_A_DEC_MSG(LOGL_ERROR, "Assignment Complete: unable to decode remote RTP IP address\n");
 			return -EINVAL;
 		}

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/19949
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: Ib650bb063404a3068b4cf3c376c6080dc29bebfe
Gerrit-Change-Number: 19949
Gerrit-PatchSet: 4
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200909/fdcab68c/attachment.htm>