Change in osmo-bsc[master]: vty: propagate result of gsm_bts_set_system_infos()

[laforge]

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/19963 )

Change subject: vty: propagate result of gsm_bts_set_system_infos()
......................................................................

vty: propagate result of gsm_bts_set_system_infos()

We should not return CMD_SUCCESS if this functions fails.

Change-Id: Id8a761593fe89cc07c2fb6e69558f44494537c47
---
M src/osmo-bsc/bsc_vty.c
1 file changed, 10 insertions(+), 2 deletions(-)

Approvals:
  laforge: Looks good to me, approved
  pespin: Looks good to me, but someone else must approve
  Jenkins Builder: Verified



diff --git a/src/osmo-bsc/bsc_vty.c b/src/osmo-bsc/bsc_vty.c
index e588ba2..3524506 100644
--- a/src/osmo-bsc/bsc_vty.c
+++ b/src/osmo-bsc/bsc_vty.c
@@ -3684,7 +3684,11 @@
 	if (acc_ramp_is_enabled(&bts->acc_ramp)) {
 		acc_ramp_abort(&bts->acc_ramp);
 		acc_ramp_set_enabled(&bts->acc_ramp, false);
-		gsm_bts_set_system_infos(bts);
+		if (gsm_bts_set_system_infos(bts) != 0) {
+			vty_out(vty, "%% Filed to (re)generate System Information "
+				"messages, check the logs%s", VTY_NEWLINE);
+			return CMD_WARNING;
+		}
 	}
 
 	return CMD_SUCCESS;
@@ -4828,7 +4832,11 @@
 		return CMD_WARNING;
 	}
 
-	gsm_bts_set_system_infos(bts);
+	if (gsm_bts_set_system_infos(bts) != 0) {
+		vty_out(vty, "%% Filed to (re)generate System Information "
+			"messages, check the logs%s", VTY_NEWLINE);
+		return CMD_WARNING;
+	}
 
 	return CMD_SUCCESS;
 }

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/19963
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Id8a761593fe89cc07c2fb6e69558f44494537c47
Gerrit-Change-Number: 19963
Gerrit-PatchSet: 3
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200908/64bf02ef/attachment.htm>