This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
laforge gerrit-no-reply at lists.osmocom.orglaforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/20040 ) Change subject: usb: handle failed transfers ...................................................................... usb: handle failed transfers This fixes the crash with external power if usb is disconected and plugged in again, upon ep reset the completion cbs are called, but we can obviously not interact with those EPs at that time and resubmit buffers. Change-Id: Icff17673b4d1d1616ee733580bdd6b5203b87139 Closes: SYS#4908 --- M sysmoOCTSIM/main.c 1 file changed, 9 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/sysmoOCTSIM/main.c b/sysmoOCTSIM/main.c index 08f38ec..101af30 100644 --- a/sysmoOCTSIM/main.c +++ b/sysmoOCTSIM/main.c @@ -230,6 +230,9 @@ llist_add_tail_at(&msg->list, &g_ccid_s.out_ep.list); g_ccid_s.out_ep.in_progress = NULL; + if(code != USB_XFER_DONE) + return; + /* submit another [free] msgb to receive the next transfer */ submit_next_out(); } @@ -244,6 +247,9 @@ llist_add_tail_at(&msg->list, &g_ccid_s.free_q); g_ccid_s.in_ep.in_progress = NULL; + if(code != USB_XFER_DONE) + return; + /* submit the next pending to-be-transmitted msgb (if any) */ submit_next_in(); } @@ -258,6 +264,9 @@ llist_add_tail_at(&msg->list, &g_ccid_s.free_q); g_ccid_s.irq_ep.in_progress = NULL; + if(code != USB_XFER_DONE) + return; + /* submit the next pending to-be-transmitted msgb (if any) */ submit_next_irq(); } -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/20040 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: Icff17673b4d1d1616ee733580bdd6b5203b87139 Gerrit-Change-Number: 20040 Gerrit-PatchSet: 2 Gerrit-Owner: Hoernchen <ewild at sysmocom.de> Gerrit-Reviewer: Hoernchen <ewild at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200908/eb4954ed/attachment.htm>