Change in osmo-ttcn3-hacks[master]: mgw: Fix logic in test TC_two_crcx_mdcx_and_rtp_osmux

[pespin]

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20035 )


Change subject: mgw: Fix logic in test TC_two_crcx_mdcx_and_rtp_osmux
......................................................................

mgw: Fix logic in test TC_two_crcx_mdcx_and_rtp_osmux

rtpem should be set to BIDIR at the same time where MDCX "sendrecv" is
sent, otherwise if MGW sends us RTP packets (because we set the conn to
sendrecv) they will be counted incorrectly in
stats[0].num_pkts_rx_err_disabled.

This issue doesn't trigger in current code because the MGW doesn't know
anyway the remote IP address of the other connection until an MDCX is
sent to it. However, if for whatever reason the IP address is known (for
instance because it is set during CRCX, which will be done in next
commits), then RTP messages would be sent and the error counter would
be > 0.

Change-Id: I8f2c4e497e522fc17e5cfe76987f802265c486ab
---
M mgw/MGCP_Test.ttcn
1 file changed, 4 insertions(+), 4 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/35/20035/1

diff --git a/mgw/MGCP_Test.ttcn b/mgw/MGCP_Test.ttcn
index 429d337..c6fe15b 100644
--- a/mgw/MGCP_Test.ttcn
+++ b/mgw/MGCP_Test.ttcn
@@ -1331,6 +1331,9 @@
 
 		/* The first leg will now be switched into bidirectional
 		 * mode, but we do not expect any data comming back yet. */
+		f_rtpem_mode(RTPEM[0], RTPEM_MODE_BIDIR);
+		stats_osmux := f_osmuxem_stats_get(OsmuxEM);
+		num_pkts_tx[1] := stats_osmux.num_pkts_tx;
 		f_flow_modify(RTPEM[0], ep, call_id, "sendrecv", flow[0]);
 		f_sleep(0.5);
 		stats_rtp := f_rtpem_stats_get(RTPEM[0]);
@@ -1347,12 +1350,9 @@
 		/* When the second leg is switched into bidirectional mode
 		 * as well, then the MGW will connect the two together and
 		 * we should see RTP streams passing through from both ends. */
-		f_rtpem_mode(RTPEM[0], RTPEM_MODE_BIDIR);
 		f_osmuxem_mode(OsmuxEM, OSMUXEM_MODE_BIDIR);
 		stats_rtp := f_rtpem_stats_get(RTPEM[0]);
-		num_pkts_tx[0] := stats_rtp.num_pkts_tx
-		stats_osmux := f_osmuxem_stats_get(OsmuxEM);
-		num_pkts_tx[1] := stats_osmux.num_pkts_tx
+		num_pkts_tx[0] := stats_rtp.num_pkts_tx;
 
 		if (crcx_osmux_wildcard) {
 			/* For now we must set same CID as the MGW recvCID,

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20035
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I8f2c4e497e522fc17e5cfe76987f802265c486ab
Gerrit-Change-Number: 20035
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200908/b63b012f/attachment.htm>