Change in osmo-ttcn3-hacks[master]: mgw: Allow setting udp ip/port with wildcard osmux in f_flow_create_o...

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Tue Sep 8 16:21:07 UTC 2020


pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20033 )


Change subject: mgw: Allow setting udp ip/port with wildcard osmux in f_flow_create_osmux()
......................................................................

mgw: Allow setting udp ip/port with wildcard osmux in f_flow_create_osmux()

This will be needed once IPv4+IPv6 support is used, since we want to set
the remote IP addr in CRCX for convinience to get an IP adr from ther
same family during CRCX, while still allowing for testing Osmux CID
wildcard value.

Change-Id: I3abd80b1c0053004aab3d03e09fada1129a59765
---
M mgw/MGCP_Test.ttcn
1 file changed, 7 insertions(+), 4 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/33/20033/1

diff --git a/mgw/MGCP_Test.ttcn b/mgw/MGCP_Test.ttcn
index 24bfdaf..deb9f3e 100644
--- a/mgw/MGCP_Test.ttcn
+++ b/mgw/MGCP_Test.ttcn
@@ -417,10 +417,13 @@
 			 * part that tells the MGW where we are listening for Osmux streams
 			 * that come from the MGW. We get a fully working connection in
 			 * one go. */
-			rx_hdl := c_OsmuxemDefaultRxHandle;
-			rx_hdl.cid := flow.osmux_cid;
-			f_osmuxem_register_rxhandle(pt, rx_hdl);
-			flow.osmux_cid_sent := true;
+			if (flow.osmux_cid != -1) {
+				/* We may still want to negotiate osmux CID later at MDCX */
+				rx_hdl := c_OsmuxemDefaultRxHandle;
+				rx_hdl.cid := flow.osmux_cid;
+				f_osmuxem_register_rxhandle(pt, rx_hdl);
+				flow.osmux_cid_sent := true;
+			}
 			cmd := ts_CRCX_osmux(get_next_trans_id(), ep, mode, call_id, flow.osmux_cid);
 			cmd.sdp := ts_SDP(flow.em.hostname, flow.em.hostname, "23", "42",
 					  flow.em.portnr, { int2str(flow.pt) }, attributes);

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20033
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I3abd80b1c0053004aab3d03e09fada1129a59765
Gerrit-Change-Number: 20033
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200908/9a0a981f/attachment.htm>


More information about the gerrit-log mailing list