This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
fixeria gerrit-no-reply at lists.osmocom.orgfixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20015 )
Change subject: library/BSSAP_LE_Types: fix wrong field order in PDU_BSSAP_LE
......................................................................
Patch Set 1:
> Patch Set 1: Code-Review-2
>
> I'm pretty sure that the current ordering matches, because we have to remove the 'FIELDORDER("msg")'. I also had a patch changing the spare and discriminator order, and hacked a 1 into the discriminator to verify. So the way to go is to remove the "msb", not change the order.
In BSSAP_LE_Types.ttcn we defile MSB globally, but in PDU_BSSAP_LE we use LSB order (from right to left), so it's wrong. Either we remove the global MSB attribute (I would rather explicitly change it to LSB and keep in the bottom), or follow the MSB order and place them from left to right.
> I hope I didn't get something completely wrong, since you also said you successfully decoded a message with this code? That part still confuses me a little bit.
Given that that in your sample ('000E2B44010005080062F2240017002A'O) contains '00'O at that position, it does not matter which way you place those fields.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20015
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ie9bbf99df0b189846c8ea3159bfd3c9a0ee5df2a
Gerrit-Change-Number: 20015
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Assignee: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-Comment-Date: Tue, 08 Sep 2020 15:34:14 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200908/ba333698/attachment.htm>