Change in osmo-pcu[master]: encoding: use CSN.1 codec to generate Packet Uplink Assignment

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

fixeria gerrit-no-reply at lists.osmocom.org
Mon Sep 7 19:48:14 UTC 2020


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/19787 )

Change subject: encoding: use CSN.1 codec to generate Packet Uplink Assignment
......................................................................


Patch Set 4:

(1 comment)

https://gerrit.osmocom.org/c/osmo-pcu/+/19787/2/src/encoding.cpp 
File src/encoding.cpp:

https://gerrit.osmocom.org/c/osmo-pcu/+/19787/2/src/encoding.cpp@538 
PS2, Line 538: /* generate uplink assignment */
> May be good idea documenting that "block" should be zero initialized by the caller.
Done, see also https://gerrit.osmocom.org/c/osmo-pcu/+/20014.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/19787
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I2850b91e0043cdca8ae7498a5fc727eeedd029b6
Gerrit-Change-Number: 19787
Gerrit-PatchSet: 4
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Mon, 07 Sep 2020 19:48:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200907/b49acd57/attachment.htm>


More information about the gerrit-log mailing list