Change in osmo-ttcn3-hacks[master]: PCU_Tests: introduce and use f_TC_pcuif_fh_params_gen()

[fixeria]

fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19990 )

Change subject: PCU_Tests: introduce and use f_TC_pcuif_fh_params_gen()
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19990/1/pcu/PCU_Tests.ttcn 
File pcu/PCU_Tests.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19990/1/pcu/PCU_Tests.ttcn@2165 
PS1, Line 2165: private function f_TC_pcuif_fh_params_gen(integer ma_len)
> I don't really understand the argument of why the linked patch would prevent this to be a template. […]
It wouldn't, but this is how it would look like:

  private template ts_TC_pcuif_fh_params(integer ma_len) := {
    tsc := f_rnd_int(7),
    hsn := f_rnd_int(63),
    maio := f_rnd_int(63),
    ma := f_pad_bit(f_rnd_bitstring(2 + f_rnd_int(ma_len - 2)), 64, '0'B)
  };

this looks cumbersome and less readable to me. If it's ok for you, I can amend the patch.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19990
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I297b52410afafedad51d5b51734e946c4d62e8d2
Gerrit-Change-Number: 19990
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Mon, 07 Sep 2020 08:27:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy at sysmocom.de>
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Comment-In-Reply-To: laforge <laforge at osmocom.org>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200907/bd525f29/attachment.htm>