This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
laforge gerrit-no-reply at lists.osmocom.orglaforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/19793 ) Change subject: abis_rsl: prioritize emergency calls over regular calls ...................................................................... Patch Set 4: Code-Review+1 (1 comment) I hope this is finally the last comment. Happy to give +2 if that one is addressed. https://gerrit.osmocom.org/c/osmo-bsc/+/19793/4/src/osmo-bsc/abis_rsl.c File src/osmo-bsc/abis_rsl.c: https://gerrit.osmocom.org/c/osmo-bsc/+/19793/4/src/osmo-bsc/abis_rsl.c@1403 PS4, Line 1403: rqd_first I would simply use llist_first_entry(&bts->chan_rqd_queue) here rather than caching the first element (rqd_first). Let's avoid strange special cases. llist_first_entry is also only one pointer dereference, so it is not more expensive. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/19793 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: If8651265928797dbda9f528b544931dcfa4a0b36 Gerrit-Change-Number: 19793 Gerrit-PatchSet: 4 Gerrit-Owner: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de> Gerrit-Comment-Date: Mon, 07 Sep 2020 08:03:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200907/bf8ee0a5/attachment.htm>