This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
laforge gerrit-no-reply at lists.osmocom.orglaforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/19992 ) Change subject: Revert "sip: Specify invite contact tag" ...................................................................... Revert "sip: Specify invite contact tag" This reverts commit 52b2afce2ca902bbae4a550d03d471be784efe28. The contact header is generated by the original sofia-sip library. By adding the contact header explicit as user header it violates the SIP RFC because sofia will add the Contact header to the BYE message as well. Let's fix the bugs in the freeswitch sofia-sip and make it compatible (not bug compatible) with the original sofia-sip. Change-Id: I712f17fecbc372d1e486e80673a548e281b37800 --- M src/sip.c 1 file changed, 0 insertions(+), 5 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/src/sip.c b/src/sip.c index 61916c9..c635542 100644 --- a/src/sip.c +++ b/src/sip.c @@ -597,9 +597,6 @@ called_num, agent->app->sip.remote_addr, agent->app->sip.remote_port); - char *contact = talloc_asprintf(leg, "sip:%s:%d", - agent->app->sip.local_addr, - agent->app->sip.local_port); char *sdp = sdp_create_file(leg, other, sdp_sendrecv); leg->state = SIP_CC_INITIAL; @@ -607,7 +604,6 @@ nua_invite(leg->nua_handle, SIPTAG_FROM_STR(from), SIPTAG_TO_STR(to), - SIPTAG_CONTACT_STR(contact), NUTAG_MEDIA_ENABLE(0), SIPTAG_CONTENT_TYPE_STR("application/sdp"), SIPTAG_PAYLOAD_STR(sdp), @@ -616,7 +612,6 @@ leg->base.call->remote = &leg->base; talloc_free(from); talloc_free(to); - talloc_free(contact); talloc_free(sdp); return 0; } -- To view, visit https://gerrit.osmocom.org/c/osmo-sip-connector/+/19992 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sip-connector Gerrit-Branch: master Gerrit-Change-Id: I712f17fecbc372d1e486e80673a548e281b37800 Gerrit-Change-Number: 19992 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis at fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu> Gerrit-Reviewer: matt9j <matt9j at cs.washington.edu> Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200907/dd5682a6/attachment.htm>