This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
fixeria gerrit-no-reply at lists.osmocom.orgfixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19995 ) Change subject: BSC_Tests/hopping: fix: do not reduce Mobile Allocation bit-mask ...................................................................... BSC_Tests/hopping: fix: do not reduce Mobile Allocation bit-mask My initial assumption was that we can skip redundant '0'B bits or even '00'O octets in the Mobile Allocation IE, and thus reduce the overall size of this element. Unfortunately, this is wrong. 3GPP TS 44.018, section 10.5.2.21 clearly states that the Mobile Allocation IE contains a bit-string of size NF, where NF is the number of frequencies in the cell allocation. If NF % 8 != 0, then '0'B padding bits must be appended to make it octet-aligned. In other words, if the cell allocation contains let's say 13 frequencies, but a hopping timeslot makes use of only a small fraction of it (e.g. 4 first channels), we would still need to transmit at least 13 bits (+padding), including all redundant bits and octets. Change-Id: Ia79efc9aa07b5088913d6679715f351d30f48d13 Related: SYS#4868, OS#4545 --- M bsc/BSC_Tests.ttcn 1 file changed, 1 insertion(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/95/19995/1 diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn index 8944447..de35e23 100644 --- a/bsc/BSC_Tests.ttcn +++ b/bsc/BSC_Tests.ttcn @@ -6889,7 +6889,6 @@ var bitstring full_mask := f_pad_bit(''B, 1024, '0'B); var bitstring slot_mask := f_pad_bit(''B, 1024, '0'B); var bitstring ma_mask := ''B; - var integer ma_mask_len := 0; /* Compose the full bit-mask (all channels, up to 1024 entries) */ for (var integer i := 0; i < lengthof(fhp); i := i + 1) { @@ -6913,15 +6912,13 @@ /* FIXME: ma_mask := ma_mask & slot_mask[i]; // triggers a bug in TITAN */ if (slot_mask[i] == '1'B) { ma_mask := ma_mask & '1'B; - ma_mask_len := lengthof(ma_mask); } else { ma_mask := ma_mask & '0'B; } } /* Ensure that ma_mask is octet-aligned */ - ma_mask := substr(ma_mask, 0, ma_mask_len); - ma_mask_len := (ma_mask_len + 8 - 1) / 8; + var integer ma_mask_len := (lengthof(ma_mask) + 8 - 1) / 8; ma_mask := f_pad_bit(ma_mask, ma_mask_len * 8, '0'B); return { len := ma_mask_len, ma := ma_mask }; -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19995 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia79efc9aa07b5088913d6679715f351d30f48d13 Gerrit-Change-Number: 19995 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de> Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200906/ea35855d/attachment.htm>