This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
matt9j gerrit-no-reply at lists.osmocom.orgmatt9j has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/19992 ) Change subject: Revert "sip: Specify invite contact tag" ...................................................................... Patch Set 1: > Patch Set 1: > > This change seems correct to me so I'll provide a +1 for code review. I will defer to the community two questions though: > > Firstly, is there a correct way to specify the contact header as a library user of sofia-sip? I am not sure if having the library infer the contact header is the ideal behavior, since this functionality was removed in freeswitch sofia-sip years ago and has not been raised there as an issue. If the contact header is being included in the BYE message against the RFC, is that an additional bug which should be filed, or did I not specify the contact header correctly? As stated in my original patch I am not a sip expert, so I will defer to the collective experience of the community here. > > Secondly, I am not sure when changes will be made to freeswitch's library. Reverting this patch now will make osmo-sip-connector and freeswitch's libsofia-sip incompatible again. I can raise this issue in the freeswitch slack and on github again, but I am not sure when it will be addressed. It may be worth considering holding on merging this revert until there is a clear path forward on that end. I can patch my local build, but anyone else using freeswitch with osmo-sip-connector will run into the same problem. It seems like I currently do not have permissions to edit the code review label yet, but have reviewed the change and commit message. -- To view, visit https://gerrit.osmocom.org/c/osmo-sip-connector/+/19992 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sip-connector Gerrit-Branch: master Gerrit-Change-Id: I712f17fecbc372d1e486e80673a548e281b37800 Gerrit-Change-Number: 19992 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis at fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu> Gerrit-Reviewer: matt9j <matt9j at cs.washington.edu> Gerrit-Comment-Date: Sat, 05 Sep 2020 23:20:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200905/679d70ff/attachment.htm>