Change in osmo-pcu[master]: encoding: implement handing of hopping parameters

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

fixeria gerrit-no-reply at lists.osmocom.org
Sat Sep 5 18:01:22 UTC 2020


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/19788 )

Change subject: encoding: implement handing of hopping parameters
......................................................................


Patch Set 3:

(1 comment)

https://gerrit.osmocom.org/c/osmo-pcu/+/19788/2/src/encoding.cpp 
File src/encoding.cpp:

https://gerrit.osmocom.org/c/osmo-pcu/+/19788/2/src/encoding.cpp@689 
PS2, Line 689: 	gen_freq_params(fp, tbf);
> IMHO this should be called and cached whenever the FH properties change, not every time we want to g […]
I will implement this in a separate change if you don't mind.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/19788
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I8adc0cdb1b05a87b4df5d4bc196f6d381283a06f
Gerrit-Change-Number: 19788
Gerrit-PatchSet: 3
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Sat, 05 Sep 2020 18:01:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200905/3a03d59b/attachment.htm>


More information about the gerrit-log mailing list