This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
pespin gerrit-no-reply at lists.osmocom.orgpespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/19143 ) Change subject: socket: introduce osmo_sock_init_osa & osmo_sock_init_osa_ofd ...................................................................... Patch Set 20: (1 comment) https://gerrit.osmocom.org/c/libosmocore/+/19143/20/src/socket.c File src/socket.c: https://gerrit.osmocom.org/c/libosmocore/+/19143/20/src/socket.c@1019 PS20, Line 1019: return osmo_fd_init_ofd(ofd, osmo_sock_init_osa(type, proto, local, remote, flags)); I think I already commented on this: First check for return of osmo_sock_init_osa(), and if it fails return early, don't pass it to osmo_fd_init_ofd. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/19143 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I1eece543e3241ef0e095eb63bb831f7c15a16794 Gerrit-Change-Number: 19143 Gerrit-PatchSet: 20 Gerrit-Owner: lynxis lazus <lynxis at fe80.eu> Gerrit-Assignee: pespin <pespin at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-CC: neels <nhofmeyr at sysmocom.de> Gerrit-Comment-Date: Fri, 04 Sep 2020 11:34:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200904/2722ffc7/attachment.htm>