Change in osmo-ttcn3-hacks[master]: msc: Introduce test TC_lu_and_mo_call_ipv6

[laforge]

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19974 )

Change subject: msc: Introduce test TC_lu_and_mo_call_ipv6
......................................................................


Patch Set 1:

(1 comment)

This change is ready for review.

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19974/1/msc/BSC_ConnectionHandler.ttcn 
File msc/BSC_ConnectionHandler.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19974/1/msc/BSC_ConnectionHandler.ttcn@1328 
PS1, Line 1328: if (f_mgcp_addr2addrtype(cpars.mgw_conn_1.mgw_rtp_ip) == "IP6") {
              : 		tla_ass := tr_BSSMAP_IE_AoIP_TLA6(f_inet6_addr(cpars.mgw_conn_1.mgw_rtp_ip), ?);
              : 	} else {
              : 		tla_ass := tr_BSSMAP_IE_AoIP_TLA4(f_inet_addr(cpars.mgw_conn_1.mgw_rtp_ip), ?);
              : 	}
one could hide all of this in a function that returns the "template BSSMAP_IE_AoIP_TransportLayerAddress" and does the conditional / check internally.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19974
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Id616926dd4a9febc4268eea2ee1e377b2d22753a
Gerrit-Change-Number: 19974
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Fri, 04 Sep 2020 07:36:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200904/188f20ab/attachment.htm>