This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
fixeria gerrit-no-reply at lists.osmocom.orgfixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/19962 ) Change subject: SI Type 4: prevent potential buffer overflow ...................................................................... Patch Set 2: > Patch Set 2: > > So we never send SI4 messages then? I'm not getting the rationale in this scenario. Can you please explain a bit more? Well, I think it's up to the caller of generate_si4() to decide what to do. As far as I can see from the code, gsm_generate_si() would log an error message and propagate -ENOMEM to gsm_bts_trx_set_system_infos(). The later in its turn would propagate the error to gsm_bts_set_system_infos()... oh, and here I realized that we do not check it's return value :/ -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/19962 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I2e3553865096faecda6bb22fc25b83fd47b738c4 Gerrit-Change-Number: 19962 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de> Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-CC: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Thu, 03 Sep 2020 11:05:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200903/00e25647/attachment.htm>