Change in libosmocore[master]: socket: add osmo_sockaddr_cmp()

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

lynxis lazus gerrit-no-reply at lists.osmocom.org
Wed Sep 2 16:31:24 UTC 2020


lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/19415 )

Change subject: socket: add osmo_sockaddr_cmp()
......................................................................


Patch Set 16:

(9 comments)

https://gerrit.osmocom.org/c/libosmocore/+/19415/11/src/socket.c 
File src/socket.c:

https://gerrit.osmocom.org/c/libosmocore/+/19415/11/src/socket.c@1562 
PS11, Line 1562: /*! Compare two osmo_sockaddr. Return 0 if they are same
> "the same". End with a ".". Actually the \return is already below.
Done


https://gerrit.osmocom.org/c/libosmocore/+/19415/11/src/socket.c@1563 
PS11, Line 1563:  * \brief osmo_sockaddr_cmp
> we use AUTO_BRIEF, so drop this \brief line
Done


https://gerrit.osmocom.org/c/libosmocore/+/19415/11/src/socket.c@1566 
PS11, Line 1566:  * \return 0 if a and b are equal.
> the naming of "cmp" implies being able to use the return code for sorting. […]
Done


https://gerrit.osmocom.org/c/libosmocore/+/19415/11/src/socket.c@1570 
PS11, Line 1570: 	if (!a && !b)
> this could be just […]
Done


https://gerrit.osmocom.org/c/libosmocore/+/19415/11/src/socket.c@1573 
PS11, Line 1573: 		return 1;
> -1
Done


https://gerrit.osmocom.org/c/libosmocore/+/19415/11/src/socket.c@1577 
PS11, Line 1577: 		return 1;
> return OSMO_CMP(a->.., b->.. […]
Done


https://gerrit.osmocom.org/c/libosmocore/+/19415/11/src/socket.c@1583 
PS11, Line 1583: 			 a->u.sin.sin_port == b->u.sin.sin_port);
> cleaner, type wise, would be to return <condition> ? 0 : 1 […]
Done


https://gerrit.osmocom.org/c/libosmocore/+/19415/11/src/socket.c@1585 
PS11, Line 1585: 		/* AF_INET6 usally not contain any padding */
> "does not"
Done


https://gerrit.osmocom.org/c/libosmocore/+/19415/11/src/socket.c@1588 
PS11, Line 1588: 		/* fallback to memcmp for remaing AF */
> "remaining"
Done



-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/19415
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I2d12ebae2710ffd17cf071e6ada0804e73f87dd6
Gerrit-Change-Number: 19415
Gerrit-PatchSet: 16
Gerrit-Owner: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Wed, 02 Sep 2020 16:31:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels <nhofmeyr at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200902/146e1994/attachment.htm>


More information about the gerrit-log mailing list