Change in osmo-bsc[master]: lchan_fsm: make rsl mode-modify working again

[neels]

neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/19792 )

Change subject: lchan_fsm: make rsl mode-modify working again
......................................................................


Patch Set 2: Code-Review-1

(3 comments)

Thanks!

Here is a diff that you can join into this patch if you agree. It contains:
- in lchan_fsm.dot, a transition is missing;
- add lchan.msc changes
- add assignment.msc changes
http://git.osmocom.org/osmo-bsc/commit/?h=neels/mode_modif&id=04aeff09ecad83bbaeaf8def353eb21d375876f4

voting -1 because of the missing 'return', see below

https://gerrit.osmocom.org/c/osmo-bsc/+/19792/1/src/osmo-bsc/lchan_fsm.c 
File src/osmo-bsc/lchan_fsm.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/19792/1/src/osmo-bsc/lchan_fsm.c@923 
PS1, Line 923: 			lchan_rtp_fsm_start(lchan);
> I would suppose there are such situations, let's say you start a USSD command just after ending a ca […]
I assume it is also possible that the MSC requests a re-assignment to a different voice codec.

At least that could be useful in osmo-msc when we want to avoid transcoding, e.g. after the other call leg handovered to a different codec.

Or actually also when establishing a call, in osmo-msc MO currently determines a voice codec and does Assignment, and only later does the MT side communicate its codec capabilities. We may want to modify the codec again before bridging the call legs.


https://gerrit.osmocom.org/c/osmo-bsc/+/19792/2/src/osmo-bsc/lchan_fsm.c 
File src/osmo-bsc/lchan_fsm.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/19792/2/src/osmo-bsc/lchan_fsm.c@803 
PS2, Line 803: 	else {
( else if (...)  )


https://gerrit.osmocom.org/c/osmo-bsc/+/19792/2/src/osmo-bsc/lchan_fsm.c@1011 
PS2, Line 1011: 			lchan_fail("MODE MODIFY not implemented when RTP voice stream is already active (VOICE => SIGNALLING?)\n");
missing 'return;' !

it could be voice => voice too, to change the codec



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/19792
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I2c5a283b1ee33745cc1fcfcc09a0f9382224e2eb
Gerrit-Change-Number: 19792
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Comment-Date: Wed, 02 Sep 2020 14:42:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: dexter <pmaier at sysmocom.de>
Comment-In-Reply-To: neels <nhofmeyr at sysmocom.de>
Comment-In-Reply-To: laforge <laforge at osmocom.org>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200902/df35fbd6/attachment.htm>