Change in osmo-gsm-tester[master]: enb_srs: add sleep after stopping srsENB to allow log flush

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

srs_andre gerrit-no-reply at lists.osmocom.org
Tue Sep 1 20:26:46 UTC 2020


srs_andre has submitted this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/19858 )

Change subject: enb_srs: add sleep after stopping srsENB to allow log flush
......................................................................

enb_srs: add sleep after stopping srsENB to allow log flush

add similar concept used in the UE to allow the process to flush
the logs

Change-Id: I9f8341869f89cd7ae845072b9da4f6070fa2d242
---
M src/osmo_gsm_tester/obj/enb_srs.py
1 file changed, 12 insertions(+), 0 deletions(-)

Approvals:
  Jenkins Builder: Verified
  pespin: Looks good to me, approved



diff --git a/src/osmo_gsm_tester/obj/enb_srs.py b/src/osmo_gsm_tester/obj/enb_srs.py
index a945319..aa2ec87 100644
--- a/src/osmo_gsm_tester/obj/enb_srs.py
+++ b/src/osmo_gsm_tester/obj/enb_srs.py
@@ -21,6 +21,7 @@
 import pprint
 
 from ..core import log, util, config, template, process, remote
+from ..core.event_loop import MainLoop
 from . import enb
 from . import rfemu
 from .srslte_common import srslte_common
@@ -70,6 +71,7 @@
         self.remote_pcap_file = None
         self.enable_pcap = False
         self.metrics_file = None
+        self.stop_sleep_time = 6 # We require at most 5s to stop
         self.testenv = testenv
         self._additional_args = []
         if not rf_type_valid(conf.get('rf_dev_type', None)):
@@ -80,6 +82,10 @@
             return
         if self._run_node.is_local():
             return
+
+        # Make sure we give the UE time to tear down
+        self.sleep_after_stop()
+
         # copy back files (may not exist, for instance if there was an early error of process):
         try:
             self.rem_host.scpfrom('scp-back-log', self.remote_log_file, self.log_file)
@@ -94,6 +100,12 @@
         # Collect KPIs for each TC
         self.testenv.test().set_kpis(self.get_kpis())
 
+    def sleep_after_stop(self):
+        # Only sleep once
+        if self.stop_sleep_time > 0:
+            MainLoop.sleep(self.stop_sleep_time)
+            self.stop_sleep_time = 0
+
     def start(self, epc):
         self.log('Starting srsENB')
         self._epc = epc

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/19858
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Change-Id: I9f8341869f89cd7ae845072b9da4f6070fa2d242
Gerrit-Change-Number: 19858
Gerrit-PatchSet: 1
Gerrit-Owner: srs_andre <andre at softwareradiosystems.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: srs_andre <andre at softwareradiosystems.com>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200901/f088812f/attachment.htm>


More information about the gerrit-log mailing list