Change in osmo-msc[master]: Don't Store an SMS in the database when the ESME is not Bound

[keith]

keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/19935 )

Change subject: Don't Store an SMS in the database when the ESME is not Bound
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/c/osmo-msc/+/19935/1/src/libmsc/gsm_04_11.c 
File src/libmsc/gsm_04_11.c:

https://gerrit.osmocom.org/c/osmo-msc/+/19935/1/src/libmsc/gsm_04_11.c@647 
PS1, Line 647: This SMS got routed through SMPP or no receiver exists.
             : 	 * In any case, we store it in the database for further processing.
> This comment does not make sense then...
Please look at https://osmocom.org/issues/2354

I think something confusing here is that we can be dealing with either an MO SMS or an MT SMS, (submitted via SMPP) the above comment was added for the case where the MSC does not know the destination address of an MT SMS, because the MS is not attached at this time.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/19935
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I2c50904349dd4ed229b60b8468d776b817c0bd44
Gerrit-Change-Number: 19935
Gerrit-PatchSet: 1
Gerrit-Owner: keith <keith at rhizomatica.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: keith <keith at rhizomatica.org>
Gerrit-CC: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Comment-Date: Tue, 01 Sep 2020 14:55:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200901/77bc0f08/attachment.htm>