Change in osmo-trx[master]: Add support for TRXC MUTE command

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Tue Sep 1 11:43:45 UTC 2020


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/19828 )

Change subject: Add support for TRXC MUTE command
......................................................................


Patch Set 3:

(1 comment)

https://gerrit.osmocom.org/c/osmo-trx/+/19828/3/Transceiver52M/Transceiver.cpp 
File Transceiver52M/Transceiver.cpp:

https://gerrit.osmocom.org/c/osmo-trx/+/19828/3/Transceiver52M/Transceiver.cpp@1018 
PS3, Line 1018:     mStates[chan].mMuted = mute ? true : false;
> It would be nice to also add a log statement here, but this is just an idea.
We don't do it for most commands, since the general TRXC logging is enough. It only makes sense for complex commands like setformat negotiations.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/19828
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: I39983d026ad54c479aa224968e9491d01f30dc35
Gerrit-Change-Number: 19828
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Hoernchen <ewild at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: tnt <tnt at 246tNt.com>
Gerrit-Comment-Date: Tue, 01 Sep 2020 11:43:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200901/35cbc996/attachment.htm>


More information about the gerrit-log mailing list