This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
fixeria gerrit-no-reply at lists.osmocom.orgfixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20967 ) Change subject: pcu: Introduce test TC_dl_multislot_tbf_ms_class_from_2phase ...................................................................... Patch Set 3: Code-Review+1 (5 comments) https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20967/3/pcu/PCU_Tests.ttcn File pcu/PCU_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20967/3/pcu/PCU_Tests.ttcn@252 PS3, Line 252: ra := bit2int(chan_req_def); This is why I don't like this comment formatting style: sometimes it's hard to see where the comment ends and where the code starts... (Especially without the syntax highlighting in Gerrit). https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20967/3/pcu/PCU_Tests.ttcn@274 PS3, Line 274: /* So you mix three different comment formatting styles to make everyone happy? ;) I know it may sound like bike-shedding, but still, code consistency matters. https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20967/3/pcu/PCU_Tests.ttcn@1169 PS3, Line 1169: var PollFnCtx pollctx; Idea: I think it would be really nice to make this part of GprsMs, so there would be no need to mess up with (sometimes unused, but required) 'poll_fn' argument. https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20967/3/pcu/PCU_Tests.ttcn@1201 PS3, Line 1201: nr := pollctx.tstrxbts unrelated? https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20967/3/pcu/PCU_Tests.ttcn@1736 PS3, Line 1736: /* Only 1 TRX with 8 PDCH */ Looks like we need some API for this kind of stuff. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20967 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie0035bab79c286a968394d7b724d975f43d187ce Gerrit-Change-Number: 20967 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de> Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Comment-Date: Sat, 31 Oct 2020 12:13:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201031/785141fd/attachment.htm>