This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
fixeria gerrit-no-reply at lists.osmocom.orgfixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/20980 ) Change subject: measurement: ignore lost FACCH/H uplink measurements ...................................................................... Patch Set 1: Code-Review-1 (3 comments) This approach relies on buggy behavior of osmo-bts-trx sending only one BFI instead of two. We need to fix osmo-bts-trx instead of adding such FACCH/H specific workarounds to the code? I hope the other BTS models send two BFIs on receipt of FACCH/H. https://gerrit.osmocom.org/c/osmo-bts/+/20980/1//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/c/osmo-bts/+/20980/1//COMMIT_MSG@9 PS1, Line 9: FACCH channel ist It's not the 'channel' that is spread over 6 bursts, but a frame, right? So 'FACCH frame is' looks more logical here. https://gerrit.osmocom.org/c/osmo-bts/+/20980/1//COMMIT_MSG@11 PS1, Line 11: up with one uplink measurement sample less Yes, and this is not a valid behavior. We need to implement sending of the second BFI frame, because currently we send only one. Once we do that, the measurement logic would be broken again? https://gerrit.osmocom.org/c/osmo-bts/+/20980/1/src/common/measurement.c File src/common/measurement.c: https://gerrit.osmocom.org/c/osmo-bts/+/20980/1/src/common/measurement.c@670 PS1, Line 670: Lost %u UL measurements This looks and sounds confusing: we're not loosing anything... -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/20980 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ibf693aede8fffa6432cdcdcf5d52910493a1104b Gerrit-Change-Number: 20980 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de> Gerrit-Comment-Date: Fri, 30 Oct 2020 09:33:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201030/fb8bdf75/attachment.htm>