Change in osmo-ttcn3-hacks[master]: pcu: Verify TLLI for Dl Assignemnt in f_ms_rx_pkt_ass_pacch()

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Thu Oct 29 16:09:47 UTC 2020


pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20963 )

Change subject: pcu: Verify TLLI for Dl Assignemnt in f_ms_rx_pkt_ass_pacch()
......................................................................

pcu: Verify TLLI for Dl Assignemnt in f_ms_rx_pkt_ass_pacch()

The same is already done for Ul Assignment. Dl assigment check was a
TODO until now.

Change-Id: Ib44a315d9ce80da05aeee642d033198f4addf6c3
---
M pcu/GPRS_Components.ttcn
1 file changed, 5 insertions(+), 1 deletion(-)

Approvals:
  Jenkins Builder: Verified
  fixeria: Looks good to me, approved



diff --git a/pcu/GPRS_Components.ttcn b/pcu/GPRS_Components.ttcn
index 6f3e3e2..e73609f 100644
--- a/pcu/GPRS_Components.ttcn
+++ b/pcu/GPRS_Components.ttcn
@@ -331,7 +331,11 @@
 	       }
 	} else if (match(dl_block, tr_RLCMAC_DL_PACKET_ASS)) {
 		ms.dl_tbf := f_dltbf_new_from_ass_pacch(dl_block);
-		/* TODO: match tlli from ms.dl_tbf.ass.pacch with ms.tlli), or error */
+		if (ischosen(ms.dl_tbf.ass.pacch.tfi_or_tlli.tlli) and
+		    ms.dl_tbf.ass.pacch.tfi_or_tlli.tlli.tlli != ms.tlli) {
+			setverdict(fail, "Wrong TLLI ", ms.dl_tbf.ass.pacch.tfi_or_tlli.tlli.tlli, " received vs exp ", ms.tlli);
+			f_shutdown(__BFILE__, __LINE__);
+		}
 	} else {
 		setverdict(fail, "Should not happen:", dl_block);
 		f_shutdown(__BFILE__, __LINE__);

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20963
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ib44a315d9ce80da05aeee642d033198f4addf6c3
Gerrit-Change-Number: 20963
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201029/88dc592d/attachment.htm>


More information about the gerrit-log mailing list