Change in osmo-pcu[master]: cosmetic: Fix ws between if keyword and parenthesis

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Thu Oct 29 11:34:19 UTC 2020


pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/20930 )

Change subject: cosmetic: Fix ws between if keyword and parenthesis
......................................................................

cosmetic: Fix ws between if keyword and parenthesis

Change-Id: I5932f21c58e76552f7187a175b8e281c5846536c
---
M src/csn1.c
M src/encoding.cpp
M src/gsm_rlcmac.c
M src/pcu_vty_functions.cpp
M src/pdch.cpp
5 files changed, 11 insertions(+), 11 deletions(-)

Approvals:
  fixeria: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/csn1.c b/src/csn1.c
index 5b60399..fa29e27 100644
--- a/src/csn1.c
+++ b/src/csn1.c
@@ -170,7 +170,7 @@
           LOGPC(DCSN1, LOGL_DEBUG, "%s = %u | ", pDescr->sz , (unsigned)*pui8);
           /* end add the bit value to protocol tree */
         }
-        else if(pDescr->may_be_null)
+        else if (pDescr->may_be_null)
         {
            pui8  = pui8DATA(data, pDescr->offset);
            *pui8 = 0;
@@ -228,7 +228,7 @@
           remaining_bits_len -= no_of_bits;
           bit_offset += no_of_bits;
         }
-        else if(pDescr->may_be_null)
+        else if (pDescr->may_be_null)
         {
           if (no_of_bits <= 8)
           {
@@ -1502,7 +1502,7 @@
           LOGPC(DCSN1, LOGL_DEBUG, "%s = %u | ", pDescr->sz , (unsigned)*pui8);
           /* end add the bit value to protocol tree */
         }
-        else if(pDescr->may_be_null)
+        else if (pDescr->may_be_null)
         {
            LOGPC(DCSN1, LOGL_DEBUG, "%s = NULL | ", pDescr->sz);
         }
@@ -1555,7 +1555,7 @@
           remaining_bits_len -= no_of_bits;
           bit_offset += no_of_bits;
         }
-        else if(pDescr->may_be_null)
+        else if (pDescr->may_be_null)
         {
           LOGPC(DCSN1, LOGL_DEBUG, "%s = NULL | ", pDescr->sz);
         }
diff --git a/src/encoding.cpp b/src/encoding.cpp
index ecfca51..c6ec2e8 100644
--- a/src/encoding.cpp
+++ b/src/encoding.cpp
@@ -853,7 +853,7 @@
 		if (show_rbb[i] == 'R')
 			rbb_byte |= 1<< (7-(i%8));
 
-		if((i%8) == 7) {
+		if ((i%8) == 7) {
 			rbb[i/8] = rbb_byte;
 			rbb_byte = 0;
 		}
diff --git a/src/gsm_rlcmac.c b/src/gsm_rlcmac.c
index 06c721e..abb1e59 100644
--- a/src/gsm_rlcmac.c
+++ b/src/gsm_rlcmac.c
@@ -6056,7 +6056,7 @@
     LOGPC(DRLCMACDATA, LOGL_NOTICE, "E_1 = %u ", (unsigned)(data->E_1));
 
 
-    if(data->E_1 == 0) // Extension octet follows immediately
+    if (data->E_1 == 0) // Extension octet follows immediately
     {
       // Octet 3 (optional)
       i = 0;
@@ -6071,7 +6071,7 @@
         i++;
       } while((data->M[i-1] == 1)&&(data->E[i-1] == 0));
     }
-    if(data->TI == 1) // TLLI field is present
+    if (data->TI == 1) // TLLI field is present
     {
       data->TLLI = bitvec_read_field(vector, &readIndex, 32);
       LOGPC(DRLCMACDATA, LOGL_NOTICE, "TLLI = %08x ", data->TLLI);
@@ -6132,7 +6132,7 @@
     LOGPC(DRLCMACDATA, LOGL_NOTICE, "E_1 = %u ", (unsigned)(data->E_1));
 
     // Octet 3 (optional)
-    if(data->E_1 == 0)
+    if (data->E_1 == 0)
     {
       i = 0;
       do
diff --git a/src/pcu_vty_functions.cpp b/src/pcu_vty_functions.cpp
index 28a1559..416c006 100644
--- a/src/pcu_vty_functions.cpp
+++ b/src/pcu_vty_functions.cpp
@@ -79,7 +79,7 @@
 			ul_tbf->window_size(), win->v_q(), win->v_r());
 		vty_out(vty, "%s", VTY_NEWLINE);
 		vty_out(vty, " TBF Statistics:%s", VTY_NEWLINE);
-		if(GPRS == tbf->ms()->mode()) {
+		if (GPRS == tbf->ms()->mode()) {
 			vty_out_rate_ctr_group(vty, " ", ul_tbf->m_ul_gprs_ctrs);
 		} else {
 			vty_out_rate_ctr_group(vty, " ", ul_tbf->m_ul_egprs_ctrs);
@@ -92,7 +92,7 @@
 			win->window_stalled() ? " STALLED" : "");
 		vty_out(vty, "%s", VTY_NEWLINE);
 		vty_out_rate_ctr_group(vty, " ", tbf->m_ctrs);
-		if(GPRS == tbf->ms()->mode()) {
+		if (GPRS == tbf->ms()->mode()) {
 			vty_out_rate_ctr_group(vty, " ", dl_tbf->m_dl_gprs_ctrs);
 		} else {
 			vty_out_rate_ctr_group(vty, " ", dl_tbf->m_dl_egprs_ctrs);
diff --git a/src/pdch.cpp b/src/pdch.cpp
index 26604bc..c56776f 100644
--- a/src/pdch.cpp
+++ b/src/pdch.cpp
@@ -704,7 +704,7 @@
 	else
 		bts()->send_gsmtap_meas(PCU_GSMTAP_C_UL_CTRL, true, trx_no(), ts_no, GSMTAP_CHANNEL_PACCH, fn, data, data_len, meas);
 
-	if(rc < 0) {
+	if (rc < 0) {
 		LOGP(DRLCMACUL, LOGL_ERROR, "Dropping Uplink Control Block with invalid "
 		     "content, decode failed: %d)\n", rc);
 		goto free_ret;

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/20930
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I5932f21c58e76552f7187a175b8e281c5846536c
Gerrit-Change-Number: 20930
Gerrit-PatchSet: 4
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201029/1a0020ce/attachment.htm>


More information about the gerrit-log mailing list