Change in libosmocore[master]: ns2: add value strings for ns2_affecting_cause_prim_str & ns2_prim_str

[lynxis lazus]

lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/20926 )

Change subject: ns2: add value strings for ns2_affecting_cause_prim_str & ns2_prim_str
......................................................................


Patch Set 3:

(4 comments)

https://gerrit.osmocom.org/c/libosmocore/+/20926/2/include/osmocom/gprs/gprs_ns2.h 
File include/osmocom/gprs/gprs_ns2.h:

https://gerrit.osmocom.org/c/libosmocore/+/20926/2/include/osmocom/gprs/gprs_ns2.h@67 
PS2, Line 67: gprs_ns2_prim
> gprs_ns2_affecting_cause?
Done


https://gerrit.osmocom.org/c/libosmocore/+/20926/1/src/gb/gprs_ns2.c 
File src/gb/gprs_ns2.c:

https://gerrit.osmocom.org/c/libosmocore/+/20926/1/src/gb/gprs_ns2.c@212 
PS1, Line 212: 	{ NS_AFF_CAUSE_SNS_FAILURE,	"NSE SNS failure" },
> Not terminated.
Done


https://gerrit.osmocom.org/c/libosmocore/+/20926/1/src/gb/gprs_ns2.c@218 
PS1, Line 218: 	enum ns_cause _cause = cause;
> Somehow it was looking like it's not assigned. Nevermind.
Done


https://gerrit.osmocom.org/c/libosmocore/+/20926/1/src/gb/gprs_ns2.c@225 
PS1, Line 225: 	{ PRIM_NS_STATUS,	"STATUS" },
> Not terminated.
Done



-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/20926
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ibf610fbd929dddc4a4e235152447caff522d4eb2
Gerrit-Change-Number: 20926
Gerrit-PatchSet: 3
Gerrit-Owner: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Tue, 27 Oct 2020 14:25:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201027/685c79dc/attachment.htm>