Change in osmo-pcu[master]: pdch: Drop error log line about egprs not enabled

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Tue Oct 27 09:26:03 UTC 2020


pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/20929 )


Change subject: pdch: Drop error log line about egprs not enabled
......................................................................

pdch: Drop error log line about egprs not enabled

EGPRS "enabled" or "not enabled" is a bit of confusing idea, since there
are different levels of EGPRS support. For instance we may have been
instructed by config to not transmit using MCS5-9 (8PSK), or not use
MCS1-9 at all (GMSK+8PSK). However, we cannot control what the MS sends
to us, so if we arrived here, let's try to decode it anyway...

Change-Id: Ie70ec8e4a2d688762d7d320d6ad58d5a0cc52ea1
---
M src/pdch.cpp
1 file changed, 0 insertions(+), 6 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/29/20929/1

diff --git a/src/pdch.cpp b/src/pdch.cpp
index 26604bc..e4ea853 100644
--- a/src/pdch.cpp
+++ b/src/pdch.cpp
@@ -788,12 +788,6 @@
 		bts()->send_gsmtap_meas(PCU_GSMTAP_C_UL_DATA_EGPRS, true,
 					trx_no(), ts_no, GSMTAP_CHANNEL_PDTCH, fn,
 					data, data_len, meas);
-		if (!bts()->bts_data()->egprs_enabled) {
-			LOGP(DRLCMACUL, LOGL_ERROR,
-				"Got %s RLC block but EGPRS is not enabled\n",
-				mcs_name(cs));
-			return 0;
-		}
 	} else {
 		bts()->send_gsmtap_meas(PCU_GSMTAP_C_UL_DATA_GPRS, true,
 					trx_no(), ts_no, GSMTAP_CHANNEL_PDTCH, fn,

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/20929
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: Ie70ec8e4a2d688762d7d320d6ad58d5a0cc52ea1
Gerrit-Change-Number: 20929
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201027/2cfb9198/attachment.htm>


More information about the gerrit-log mailing list