This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
laforge gerrit-no-reply at lists.osmocom.orglaforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/20926 )
Change subject: ns2: add value strings for ns2_affecting_cause_prim_str & ns2_prim_str
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
https://gerrit.osmocom.org/c/libosmocore/+/20926/1/src/gb/gprs_ns2.c
File src/gb/gprs_ns2.c:
https://gerrit.osmocom.org/c/libosmocore/+/20926/1/src/gb/gprs_ns2.c@207
PS1, Line 207: { NS
i guess those are straight from the spec? I find it a bit inconsistent that Virtual-Circuit is expanded, but below NSE is not. I'd say either always use acronyms like NSVC + NSE, or expand both. Not critical, obviously.
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/20926
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ibf610fbd929dddc4a4e235152447caff522d4eb2
Gerrit-Change-Number: 20926
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Tue, 27 Oct 2020 07:45:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201027/5abff5ef/attachment.htm>