Change in osmo-pcu[master]: tbf: Implement enable_egprs() once

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Sun Oct 25 22:26:03 UTC 2020


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/20857 )

Change subject: tbf: Implement enable_egprs() once
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/c/osmo-pcu/+/20857/2/src/tbf.h 
File src/tbf.h:

https://gerrit.osmocom.org/c/osmo-pcu/+/20857/2/src/tbf.h@589 
PS2, Line 589: 	m_egprs_enabled = false;
> Unrelated: shouldn't we reset back to RLC_GPRS_SNS here?
This function is actually unused and can be removed. I'll submit a patch.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/20857
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: Id7de060318201a42e51f277f898463f4b9a84eba
Gerrit-Change-Number: 20857
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Sun, 25 Oct 2020 22:26:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201025/808d3b4e/attachment.htm>


More information about the gerrit-log mailing list