Change in osmo-bts[master]: measurement: count measurements for FACCH/H twice.

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

fixeria gerrit-no-reply at lists.osmocom.org
Thu Oct 22 18:41:23 UTC 2020


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/20840 )

Change subject: measurement: count measurements for FACCH/H twice.
......................................................................


Patch Set 2: Code-Review-1

(1 comment)

I only had a quick look at your detailed research in the ticket, and it's possible that I am missing something, but this approach looks wrong to me, sorry. We're supposed to send 2 BFIs to the upper layers on receipt of FACCH/H anyway, right? So you could ignore FACCH/F in the measurement processing code, and only handle TCH frames (including BFIs) instead of complicating the code this way.

https://gerrit.osmocom.org/c/osmo-bts/+/20840/2//COMMIT_MSG 
Commit Message:

https://gerrit.osmocom.org/c/osmo-bts/+/20840/2//COMMIT_MSG@11 
PS2, Line 11: FAACH/H
FACCH



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/20840
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Id533bb3207bac40d00d77b484619f66ea5c0774d
Gerrit-Change-Number: 20840
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Thu, 22 Oct 2020 18:41:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201022/c94dc36a/attachment.htm>


More information about the gerrit-log mailing list