This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
fixeria gerrit-no-reply at lists.osmocom.orgfixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20793 )
Change subject: bts-lapdm: Introduce test TC_normal_reestablishment
......................................................................
Patch Set 3:
(1 comment)
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20793/3/bts/BTS_Tests_LAPDm.ttcn
File bts/BTS_Tests_LAPDm.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20793/3/bts/BTS_Tests_LAPDm.ttcn@1366
PS3, Line 1366: received_ua := true;
: if (not received_estind) {
: repeat;
> this logic looks like one would better use the "interleave {}" instead of the "alt{}" statement. […]
I would say ACK, but... The 'interleave' statement is very inflexible: not only RSL/LAPDm repeat steps would need to be enable()d, but also the 'timeout' step too. The 'alt' is probably better and easier to read in this case.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20793
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I5eb07a6abf5a260e2f62c177f8c100305d44155a
Gerrit-Change-Number: 20793
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <vyanitskiy at sysmocom.de>
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Tue, 20 Oct 2020 16:14:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge at osmocom.org>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201020/98641159/attachment.htm>