Change in libosmocore[master]: select: Migrate over to poll()

[laforge]

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/20732 )

Change subject: select: Migrate over to poll()
......................................................................


Patch Set 5:

(2 comments)

FYI: v5 of the patchset has now been surviving one complete BSC_Tests.ttcn run against osmo-bsc, which is a good sign.

https://gerrit.osmocom.org/c/libosmocore/+/20732/2/src/select.c 
File src/select.c:

https://gerrit.osmocom.org/c/libosmocore/+/20732/2/src/select.c@158 
PS2, Line 158: 				   g_poll.poll_size + POLL_ALLOC_GRANULARITY);
> A process starting to alocate big quantities of fds is expected to keep allocating lots more, so you […]
Done


https://gerrit.osmocom.org/c/libosmocore/+/20732/2/src/select.c@291 
PS2, Line 291: OSMO_ASSERT
> I am also worried about this line. Do we really want to assert() on each iteration? […]
Done



-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/20732
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I9e80da68a144b36926066610d0d3df06abe09bca
Gerrit-Change-Number: 20732
Gerrit-PatchSet: 5
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Mon, 19 Oct 2020 18:27:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge at osmocom.org>
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Comment-In-Reply-To: fixeria <vyanitskiy at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201019/e837c916/attachment.htm>