Change in osmo-ttcn3-hacks[master]: PCU_Tests: add missing f_shutdown(final := true) statements

[fixeria]

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20709 )

Change subject: PCU_Tests: add missing f_shutdown(final := true) statements
......................................................................

PCU_Tests: add missing f_shutdown(final := true) statements

Otherwise those test cases may sporadically fail due to DTE:

  Sending data on the connection of port CLCK to 8:CLCK failed. (Broken pipe)

Change-Id: Ia8c934697a4e7bc39e762bf81587fea3bbe11b17
---
M pcu/PCU_Tests.ttcn
1 file changed, 7 insertions(+), 2 deletions(-)

Approvals:
  pespin: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/pcu/PCU_Tests.ttcn b/pcu/PCU_Tests.ttcn
index 34dd035..a6f052e 100644
--- a/pcu/PCU_Tests.ttcn
+++ b/pcu/PCU_Tests.ttcn
@@ -891,6 +891,8 @@
 
 	/* receive one message on BSSGP with all aggregated data in payload: */
 	BSSGP[0].receive(tr_BSSGP_UL_UD(ms.tlli, mp_gb_cfg.bvc[0].cell_id, total_payload));
+
+	f_shutdown(__BFILE__, __LINE__, final := true);
 }
 
 /* Verify PCU handles correctly CS1..4 with all possible LLC payload sizes fitting alone in one RLC block */
@@ -980,7 +982,8 @@
 		/* DL ACK/NACK sets poll+rrbp requesting PACKET CONTROL ACK */
 		f_ms_tx_ul_block(ms, ts_RLCMAC_CTRL_ACK(ms.tlli), sched_fn);
 	}
-	setverdict(pass);
+
+	f_shutdown(__BFILE__, __LINE__, final := true);
 }
 
 function f_TC_ul_data_toolong_fills_padding_cs(inout GprsMS ms, CodingScheme cs, integer cv) runs on RAW_PCU_Test_CT {
@@ -1045,7 +1048,7 @@
 	f_TC_ul_data_toolong_fills_padding_cs(ms, CS_3, 1);
 	f_TC_ul_data_toolong_fills_padding_cs(ms, CS_4, 0);
 
-	setverdict(pass);
+	f_shutdown(__BFILE__, __LINE__, final := true);
 }
 
 /* Test scenario where MS wants to send some data on PDCH against SGSN and it is
@@ -1386,6 +1389,8 @@
 
 	/* receive one message on BSSGP with all aggregated data in payload: */
 	BSSGP[0].receive(tr_BSSGP_UL_UD(ms.tlli, mp_gb_cfg.bvc[0].cell_id, total_payload));
+
+	f_shutdown(__BFILE__, __LINE__, final := true);
 }
 
 /* Verify that if PCU doesn't get an ACK for first DL block after IMM ASS, it

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20709
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ia8c934697a4e7bc39e762bf81587fea3bbe11b17
Gerrit-Change-Number: 20709
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201019/728cf1f0/attachment.htm>