Change in osmo-sgsn[master]: Log error if pdp ctx is freed while holding an active timer

[laforge]

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/20789 )

Change subject: Log error if pdp ctx is freed while holding an active timer
......................................................................

Log error if pdp ctx is freed while holding an active timer

Change-Id: Iae520be36377b27a12441defa722fd41a3cdba0a
---
M src/sgsn/gprs_sgsn.c
1 file changed, 5 insertions(+), 0 deletions(-)

Approvals:
  laforge: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/sgsn/gprs_sgsn.c b/src/sgsn/gprs_sgsn.c
index cb2c0fc..0b7c21e 100644
--- a/src/sgsn/gprs_sgsn.c
+++ b/src/sgsn/gprs_sgsn.c
@@ -511,6 +511,11 @@
 	sig_data.pdp = pdp;
 	osmo_signal_dispatch(SS_SGSN, S_SGSN_PDP_FREE, &sig_data);
 
+	if (osmo_timer_pending(&pdp->timer)) {
+		LOGPDPCTXP(LOGL_ERROR, pdp, "Freeing PDP ctx with timer %u pending\n", pdp->T);
+		osmo_timer_del(&pdp->timer);
+	}
+
 	rate_ctr_group_free(pdp->ctrg);
 	if (pdp->mm)
 		llist_del(&pdp->list);

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/20789
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: Iae520be36377b27a12441defa722fd41a3cdba0a
Gerrit-Change-Number: 20789
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201019/f113a847/attachment.htm>